Constructor init of java.lsp.server JavaPlatformProvider override#453
Merged
Achal1607 merged 1 commit intooracle:mainfrom Aug 26, 2025
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
Achal1607
reviewed
Aug 25, 2025
sid-srini
force-pushed
the
jvsc415_projectJdkHome_java_platform_override_init
branch
from
1c4202d to
427e230
Compare
Achal1607
previously approved these changes
Aug 25, 2025
Member
Achal1607
left a comment
Achal1607
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this
sid-srini
force-pushed
the
jvsc415_projectJdkHome_java_platform_override_init
branch
from
427e230 to
ff7e639
Compare
Achal1607
approved these changes
Aug 25, 2025
1. Allowed LspJavaPlatformProviderOverride to initialize the override
based on the value set for the option "netbeans.lsp.java.platform.override"
passed as a JVM system property.
2. Utilised platform override system property in Java VSCode extension
1. From the Java VSCode extension, passed the value of
"jdk.project.jdkhome" configuration to the NBLS via the JVM
system property flag "netbeans.lsp.java.platform.override".
2. This additionally allows the LspJavaPlatformProviderOverride to initialize
the JavaPlatform override during construction, avoiding any caching
of the default platform prior to the configuration being read via LSP.
sid-srini
force-pushed
the
jvsc415_projectJdkHome_java_platform_override_init
branch
from
ff7e639 to
386be22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings NetBeans PR Constructor init of java.lsp.server JavaPlatformProvider override apache/netbeans#8745 as a patch
Allowed
LspJavaPlatformProviderOverrideto initialize the override based on the value set for the option "netbeans.lsp.java.platform.override" passed as a JVM system property.Utilised platform override system property in Java VSCode extension
jdk.project.jdkhome" configuration to the NBLS via the JVM system property flag "netbeans.lsp.java.platform.override".LspJavaPlatformProviderOverrideto initialize theJavaPlatformoverride during construction, avoiding any caching of the default platform prior to the configuration being read via LSP.Thanks to @lahodaj for the idea of this fix.